Fix Version Comparison Error in YamlCreate #244669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare versions as versions and not as strings
|
|
microsoft-github-policy-service
bot
added
the
Needs-Attention
mdanish-kh
approved these changes
Apr 2, 2025
microsoft-github-policy-service
bot
added
the
Moderator-Approved
|
[Policy] Needs-Manual-Merge |
denelon
approved these changes
Apr 2, 2025
microsoft-github-policy-service
bot
added
Needs-Manual-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compare versions as versions and not as strings
Checklist for Pull Requests
Fixes an error where Zip files can't be selected in YamlCreate because
1.10.0is lexicographically less than1.4.0by explicitly casting to versions.@denelon
Microsoft Reviewers: Open in CodeFlow