Fix broken stats gathering code if no. of GCs > MAX_PHASES
#1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-sareen
force-pushed
the
fix/broken-stats-code
branch
from
2d149e4 to
25f65e2
Compare
|
The V8 binding tests failed due to some problems in the CI script. I am fixing it separately. mmtk/mmtk-v8#90 |
|
Wait to run V8 tests or merge @wks? |
Just merge it. The V8 binding only uses NoGC at this time, so there is nothing for statistics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1074 and #493.