fix: Forwarding EventSource headers to requests to reuse EventSource… #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'s Last-Event-ID, solving the session ID reuse problem during reconnection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Forwarding EventSource headers to requests to reuse EventSource's Last-Event-ID, solving the session ID reuse problem during reconnection.
Motivation and Context
The current MCP protocol in SSE mode does not yet support reconnection with sessionId. If we forward the last-event-id created by EventSource, and the SSE server delivers the sessionId as the SSE id, the client can leverage EventSource's last-event-id mechanism during reconnection to resume a connection with the same sessionId instead of issuing a new sessionId.
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context