-
Notifications
You must be signed in to change notification settings - Fork 605
StreamableHttp - Update examples and README #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possibly confusing to remove SSE at top level, given that people already currently use it? Know it's covered below under backwards compat, just wonder if maybe needs louder callout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -9,7 +9,7 @@ import { CallToolResult } from '../../types.js'; | |||
* (protocol version 2024-11-05). It mainly used for testing backward compatible clients. | |||
* | |||
* The server exposes two endpoints: | |||
* - /sse: For establishing the SSE stream (GET) | |||
* - /mcp: For establishing the SSE stream (GET) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use /sse
, though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically it doesn't matter and in this way it's much easier to re-use the same client for testing. THis example should not be used now for use cases, only for testing clients. Ideally should be deleted soon.
|
Now StreamableHttp is available, we need to update README and examples.
Note
stacked on top of #347