Ensure JSONRPCError messages are sent for streamable http #409
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, any JSONRPCError message sent when
enableJsonResponse
is true would be ignored (and response.end() never called)Motivation and Context
There's a bug when
enableJsonResponse
is true and an error is sent, say, by the protocol. The current logic will just ignore any message that isn't a JSONRPCResponse – and JSONRPCError is one of these.How Has This Been Tested?
I tested this by sending a message that would parse, but fail at the protocol layer due to no handler being found.
Breaking Changes
No
Types of changes
Checklist
Additional context