Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MCP link and update roadmap status #572

Merged
merged 2 commits into from
Apr 9, 2025
Merged

Fix MCP link and update roadmap status #572

merged 2 commits into from
Apr 9, 2025

Conversation

chritkhalil
Copy link
Contributor

@chritkhalil chritkhalil commented Apr 3, 2025 •
edited
Loading

This PR fixes two issues:

    1.  **MCP Tutorial Link:** Corrects the capitalization in the MCP tutorial link found in the News section of the README.
        *   Incorrect: `https://doc.agentscope.io/build_tutorial/mcp.html`
        *   Correct: `https://doc.agentscope.io/build_tutorial/MCP.html`
    2.  **Roadmap Status:** Updates the status markers (✅, 🚧, 📝) in `docs/ROADMAP.md` for Tool Calling and RAG features to reflect the current implementation state based on code review.

@chritkhalil chritkhalil changed the title Fix MCP tutorial link capitalization Fix MCP link and update roadmap status Apr 3, 2025
@rayrayraykk rayrayraykk self-requested a review April 8, 2025 08:58
@rayrayraykk
Copy link
Collaborator

Thanks for your contributions. Could you please also fix the URL in README_JA.md and README_ZH.md?

DavdGao
DavdGao approved these changes Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit 8dffa49 into modelscope:main Apr 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

@rayrayraykk rayrayraykk Awaiting requested review from rayrayraykk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chritkhalil @rayrayraykk @DavdGao