fix(summaryReporter): add back broken error reporting and make log reporting optional for summaryReporter #2932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7aedbaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
MichaelWest22
changed the title
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I found that in #2126 the option to add log reporting was enabled but it also replaced the logger with the reportTestFileResults BufferedLogger. However this logger flushes its log buffer as soon as reportTestFileResults stage finishes and then this logger is used for Error reporting in onTestRunFinished() and this reporting now just goes to a buffer that is never flushed. I resolved this issue by moving the error reporting logging back to TestRunnerLogger. This change could be a breaking change to some users who have worked around the lack of error reporting so I had to add a flag to enable it that defaults to false to retain existing broken behavior.
Also it is often useful to combine multiple reporters and if other reporters have log reporting like the defaultReporter it can double up log reporting in some combinations so I added a flag to optionally turn this off if needed.