-
Notifications
You must be signed in to change notification settings - Fork 271
Theseus skin selector backend #3525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexTMjugador
wants to merge
4
commits into
alex/auth-profile-extensions
Choose a base branch
from
alex/skin-selector-backend
base: alex/auth-profile-extensions
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Theseus skin selector backend #3525
AlexTMjugador
wants to merge
4
commits into
alex/auth-profile-extensions
from
alex/skin-selector-backend
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 23 out of 34 changed files in this pull request and generated 1 comment.
Files not reviewed (11)
- apps/app/capabilities/plugins.json: Language not supported
- apps/app/tauri.conf.json: Language not supported
- packages/app-lib/.sqlx/query-1937e191a7815a55274bb39a035e02a39bb04b45dbd727e5db5b5308deda4e04.json: Language not supported
- packages/app-lib/.sqlx/query-27a4ca00ab9d1647bf63287169f6dd3eed86ba421c83e74fe284609a8020bd22.json: Language not supported
- packages/app-lib/.sqlx/query-3d15e7eb66971e70500e8718236fbdbd066d51f88cd2bcfed613f756edbd2944.json: Language not supported
- packages/app-lib/.sqlx/query-3f3d3c2d77c1bcaf4044b612c3822546583aa19ea7088682d718c64ed5d5f1c5.json: Language not supported
- packages/app-lib/.sqlx/query-545b01d8cc1e79ff5d4136887fbb712aba58908a66dd7bbd64c293b9ee7a1523.json: Language not supported
- packages/app-lib/.sqlx/query-957f184e28e4921ff3922f3e74aae58e2d7a414e76906700518806e494cd0246.json: Language not supported
- packages/app-lib/.sqlx/query-9c2522e4518067192539ad270253ae1b3d75e80e52529e491e86ff370d6424b3.json: Language not supported
- packages/app-lib/.sqlx/query-aae88809ada53e13441352e315f68169cfd8226b57bacd8c270d7777fc6883ac.json: Language not supported
- packages/app-lib/migrations/20250413162050_skin-selector.sql: Language not supported
134317d
to
f37ddda
Compare
26fd06a
to
b30fc6d
Compare
f37ddda
to
143a60f
Compare
eb0de0c
to
6353588
Compare
8440ddc
to
c3d75f9
Compare
c1eb8c1
to
b95a321
Compare
c3d75f9
to
0288ce2
Compare
b95a321
to
07273d2
Compare
0288ce2
to
5566ecc
Compare
07273d2
to
00b3e02
Compare
5566ecc
to
cd19d78
Compare
00b3e02
to
d92b1ce
Compare
cd19d78
to
e95a31a
Compare
d92b1ce
to
05379b4
Compare
e95a31a
to
adcccbc
Compare
05379b4
to
8f11f2c
Compare
adcccbc
to
965de5c
Compare
This may help with issues reported by users where the access token is invalid and can't be used to join servers over long periods of time.
8f11f2c
to
c553c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces the required backend logic for a skin selector feature, building upon the profile fetching groundwork proposed in #3491. Some highlights include:
minecraft-skins
plugin for the frontend to use (seeapps/app/src/api/minecraft_skins.rs
):get_available_capes
: fetches the list of available capes for the current player.get_available_skins
: fetches the list of available skins for the current player.add_and_equip_custom_skin
: adds a custom skin to the locally stored list of available skins for the current player, and equips it in their Mojang player profile.set_default_cape
: sets the default cape for the current player.equip_skin
: equips a skin in the Mojang player profile of the current player.remove_custom_skin
: removes a custom skin from the locally stored list of available skins for the current player.unequip_skin
: unequips any skin in the Mojang player profile of the current player, resetting them to their default skin.20250413162050_skin-selector.sql
sqlx
migration.Testing
I've successfully conducted a basic verification of most of the new
minecraft-skins
commands through manualinvoke
calls in the app web development console, and did manual unit tests for the underlying data access and store mechanisms. It's still possible that actual use by frontend code will reveal further areas of improvement, however.