Skip to content

chore(eslint-config): re-enable no-duplicate-type-constituents rule COMPASS-9459 #7043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2025
+17 −27
Merged

chore(eslint-config): re-enable no-duplicate-type-constituents rule COMPASS-9459 #7043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95a58c9
chore(eslint-config): re-enable no-duplicate-type-constituents rule
gribnoysup Jun 19, 2025
d8655b1
merge main
Anemy Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion configs/eslint-config-compass/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const extraTsRules = {
'@typescript-eslint/no-explicit-any': 'warn',
'@typescript-eslint/no-base-to-string': 'warn',
'@typescript-eslint/unbound-method': 'warn',
'@typescript-eslint/no-duplicate-type-constituents': 'warn',
};

const tsRules = {
Expand Down
9 changes: 4 additions & 5 deletions packages/compass-aggregations/src/modules/pipeline-builder/pipeline-ai.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,14 +430,14 @@ export const cancelAIPipelineGeneration = (): PipelineBuilderThunkAction<
};
};

type resetIsAggregationGeneratedFromQueryAction = {
type ResetIsAggregationGeneratedFromQueryAction = {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small drive-by to match the naming scheme with other actions

type: AIPipelineActionTypes.resetIsAggregationGeneratedFromQuery;
};

export const resetIsAggregationGeneratedFromQuery =
(): PipelineBuilderThunkAction<
void,
resetIsAggregationGeneratedFromQueryAction
ResetIsAggregationGeneratedFromQueryAction
> => {
return (dispatch) => {
dispatch({
Expand Down Expand Up @@ -477,9 +477,8 @@ export type AIPipelineAction =
| AIPipelineFailedAction
| LoadGeneratedPipelineAction
| PipelineGeneratedFromQueryAction
| LoadGeneratedPipelineAction
| CancelAIPipelineGenerationAction
| resetIsAggregationGeneratedFromQueryAction
| ResetIsAggregationGeneratedFromQueryAction
| ShowInputAction
| HideInputAction
| ChangeAIPromptTextAction;
Expand Down Expand Up @@ -567,7 +566,7 @@ const aiPipelineReducer: Reducer<AIPipelineState, AIPipelineAction> = (
}

if (
isAction<resetIsAggregationGeneratedFromQueryAction>(
isAction<ResetIsAggregationGeneratedFromQueryAction>(
action,
AIPipelineActionTypes.resetIsAggregationGeneratedFromQuery
)
Expand Down
1 change: 0 additions & 1 deletion packages/compass-aggregations/src/modules/pipeline-builder/stage-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ export type StageEditorAction =
| ChangeStageValueAction
| ChangeStageOperatorAction
| ChangeStageCollapsedAction
| ChangeStageOperatorAction
| ChangeStageDisabledAction
| StageAddAction
| StageRemoveAction
Expand Down
2 changes: 1 addition & 1 deletion packages/compass-components/src/components/workspace-container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function WorkspaceContainer({
children:
| React.ReactNode
| ((
scrollTriggerRef: (node?: Element | null | undefined) => void
scrollTriggerRef: (node?: Element | null) => void
) => React.ReactNode);
}) {
const darkMode = useDarkMode();
Expand Down
3 changes: 1 addition & 2 deletions packages/compass-telemetry/src/telemetry-events.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,7 @@ type AggregationEditedEvent = ConnectionScopedEvent<{
| 'stage_renamed'
| 'stage_added'
| 'stage_deleted'
| 'stage_reordered'
| 'stage_added';
| 'stage_reordered';

/**
* The name of the stage edited.
Expand Down
24 changes: 10 additions & 14 deletions packages/connection-storage/src/compass-renderer-connection-storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ class CompassRendererConnectionStorage implements ConnectionStorage {
return ipc;
}

loadAll(
options?: { signal?: AbortSignal | undefined } | undefined
): Promise<ConnectionInfo[]> {
loadAll(options?: {
signal?: AbortSignal | undefined;
}): Promise<ConnectionInfo[]> {
return this.ipc.loadAll(options);
}

Expand Down Expand Up @@ -86,9 +86,9 @@ class CompassRendererConnectionStorage implements ConnectionStorage {
return await this.ipc.getAutoConnectInfo(autoConnectPreferences);
}

getLegacyConnections(
options?: { signal?: AbortSignal | undefined } | undefined
): Promise<{ name: string }[]> {
getLegacyConnections(options?: {
signal?: AbortSignal | undefined;
}): Promise<{ name: string }[]> {
return this.ipc.getLegacyConnections(options);
}

Expand All @@ -100,14 +100,10 @@ class CompassRendererConnectionStorage implements ConnectionStorage {
return this.ipc.deserializeConnections(args);
}

exportConnections(
args?:
| {
options?: ExportConnectionOptions | undefined;
signal?: AbortSignal | undefined;
}
| undefined
): Promise<string> {
exportConnections(args?: {
options?: ExportConnectionOptions | undefined;
signal?: AbortSignal | undefined;
}): Promise<string> {
return this.ipc.exportConnections(args);
}

Expand Down
4 changes: 1 addition & 3 deletions packages/my-queries-storage/src/pipeline-storage-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,7 @@ type StoredLegacyPipelineStage = {
stage: string;
};

function savedPipelineToText(
pipeline?: StoredLegacyPipelineStage[] | undefined
): string {
function savedPipelineToText(pipeline?: StoredLegacyPipelineStage[]): string {
const stages =
pipeline?.map(({ stageOperator, isEnabled, stage }) => {
return stageToString(stageOperator, stage, !isEnabled);
Expand Down