feat(data-modeling): export diagram to json COMPASS-9448 #7046
+826
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
reviewed
Jun 23, 2025
|
|
||
| it('renders nothing if step is not EDITING', function () { | ||
| renderDiagramEditorToolbar({ step: 'ANALYSIS_CANCELED' }); | ||
| expect(() => screen.getByTestId('diagram-editor-toolbar')).to.throw; |
There was a problem hiding this comment.
throw needs to be called to assert
gribnoysup
reviewed
Jun 23, 2025
Comment on lines
+102
to
+106
| <Radio value="json" aria-label="JSON"> | ||
| <Icon glyph="CurlyBraces" /> | ||
| {nbsp} | ||
| JSON | ||
| </Radio> |
There was a problem hiding this comment.
This doesn't match the designs where the icon is outside of the radio item, not sure if that's a deliberate choice not to follow the designs here. Also the alignments of items inside the label is slightly off, but catches the eye, in the designs everything is middle aligned, not baseline
gribnoysup
reviewed
Jun 23, 2025
Comment on lines
+61
to
+63
| // TODO: Confirm all collections are selected by default (COMPASS-9309) | ||
| // Note: We'll need to change the UI, right now the labels are disconnected from the checkboxes | ||
| await browser.clickVisible(Selectors.CreateDataModelConfirmButton); |
There was a problem hiding this comment.
You can count the checkboxes or check the <number> total collections selected text instead of waiting for this refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview
Export.to.JSON.mov
Changes in toast
Description
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes