Skip to content

Update serde to 0.7 #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2016
Merged

Update serde to 0.7 #34

merged 1 commit into from
Mar 6, 2016

Conversation

kyeah
Copy link
Contributor

@kyeah kyeah commented Mar 4, 2016

Updates serde to 0.7. As noted in #24, this is a breaking change :(

@dariusc93
Copy link

Strange.. When I apply the patches to the local repo i have of bson-rs i get the following when compiling an example made with the sample code on #24

expected `core::option::Option<bson::ordered::OrderedDocument>`,
    found `core::option::Option<bson::ordered::OrderedDocument>`
(expected struct `bson::ordered::OrderedDocument`,
    found a different struct `bson::ordered::OrderedDocument`)

There are also other related errors. I will run a split test from my own workspace to see if its my code or this pr.

Update: It looks like it is just my code and mongodb since mongo uses a different version of bson. Hopefully when this is pulled that mongodb can also update

@zonyitoo
Copy link
Contributor

zonyitoo commented Mar 5, 2016

I didn't use that in my own project. So I am Ok with this change.

Is it ready to be merged?

@dariusc93
Copy link

It's good so far for me.

@kyeah
Copy link
Contributor Author

kyeah commented Mar 6, 2016

Yeah, this is ready for merging! Once this is in, I'll make the required changes on the mongo driver.

zonyitoo added a commit that referenced this pull request Mar 6, 2016
@zonyitoo zonyitoo merged commit adbbc97 into mongodb:master Mar 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants