Skip to content

(EAI-152) check for change to chunkAlgoHash when updating embeddings #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

yakubova92
Copy link
Collaborator

@yakubova92 yakubova92 commented Dec 16, 2024

Jira: https://jira.mongodb.org/browse/EAI-152

Changes

  • Previously, updateEmbeddedContent would re-chunk if the page content changed OR chunkAlgoHash changed since the date provided
  • Now, it updates embedded content when the chunk algo has changed, even if there were no other changes to the page, essentially ignoring the since date provided

@yakubova92 yakubova92 changed the title check for change in chunkAlgoHash (EAI-152) check for change to chunkAlgoHash when updating embeddings Dec 16, 2024
@yakubova92 yakubova92 requested a review from mongodben December 16, 2024 16:09
Copy link
Collaborator

@mongodben mongodben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about caching.

and beyond that, sorry if i'm dense, but what changes are you making?

@yakubova92 yakubova92 marked this pull request as ready for review January 10, 2025 21:41
@yakubova92 yakubova92 requested a review from mongodben January 10, 2025 21:41
Copy link
Collaborator

@mongodben mongodben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about the $lookup implementation

@yakubova92 yakubova92 requested a review from mongodben January 15, 2025 22:41
Copy link
Collaborator

@mongodben mongodben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about typing

@yakubova92 yakubova92 requested a review from mongodben January 23, 2025 04:56
@yakubova92 yakubova92 requested a review from nlarew March 11, 2025 20:18
Copy link
Collaborator

@nlarew nlarew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggested tweaks + one question about the caching behavior

@yakubova92 yakubova92 requested a review from nlarew April 7, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants