-
Notifications
You must be signed in to change notification settings - Fork 69
(EAI-152) check for change to chunkAlgoHash when updating embeddings #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
packages/mongodb-rag-core/src/contentStore/updateEmbeddedContent.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about caching.
and beyond that, sorry if i'm dense, but what changes are you making?
packages/mongodb-rag-core/src/contentStore/updateEmbeddedContent.ts
Outdated
Show resolved
Hide resolved
packages/mongodb-rag-core/src/contentStore/MongoDbEmbeddedContentStore.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about the $lookup implementation
packages/mongodb-rag-core/src/contentStore/MongoDbEmbeddedContentStore.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggested tweaks + one question about the caching behavior
Jira: https://jira.mongodb.org/browse/EAI-152
Changes