-
Notifications
You must be signed in to change notification settings - Fork 36
DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image #783
Conversation
…l image to local dev image
✅ Deploy Preview for docs-atlas-cli ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/atlas-cli-deploy-docker.txt
Outdated
.. code-block:: yaml | ||
|
||
local_dev_atlas: | ||
image: mongodb/mongodb-atlas-local:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are missing
image: mongodb/mongodb-atlas-local:latest | |
image: mongodb/mongodb-atlas-local:latest | |
hostname: local_dev_atlas |
source/atlas-cli-deploy-docker.txt
Outdated
|
||
.. code-block:: yaml | ||
|
||
local_dev_atlas: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local_dev_atlas: | |
services: | |
local_dev_atlas: |
source/atlas-cli-deploy-docker.txt
Outdated
- MONGODB_INITDB_ROOT_PASSWORD=pass | ||
volumes: | ||
- data:/data/db | ||
- config:/data/configdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- config:/data/configdb | |
- config:/data/configdb | |
volumes: | |
- data: | |
- config: |
source/atlas-cli-deploy-docker.txt
Outdated
|
||
.. code-block:: yaml | ||
|
||
self_built_atlas_implementation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self_built_atlas_implementation: | |
services: | |
self_built_atlas_implementation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM + nits
source/atlas-cli-deploy-docker.txt
Outdated
the `mongodb-atlas-local <https://hub.docker.com/r/mongodb/mongodb-atlas-local>`__ image. | ||
|
||
1. Remove any existing ``command`` from your ``docker-compose.yaml`` file. Because | ||
the ``comand`` in a Docker Compose definition overrides the ``ENTRYPOINT`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the ``comand`` in a Docker Compose definition overrides the ``ENTRYPOINT`` | |
the ``command`` in a Docker Compose definition overrides the ``ENTRYPOINT`` |
source/atlas-cli-deploy-docker.txt
Outdated
defined in the ``mongodb-atlas-local`` image, you must remove any existing | ||
``command`` for the ``mongodb-atlas-local`` image to run as designed. | ||
|
||
2. There is no need to define a health check for the Atlas deployment, as this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2. There is no need to define a health check for the Atlas deployment, as this | |
2. There is no need to define a health check for the |service| deployment, as this |
source/atlas-cli-deploy-docker.txt
Outdated
|
||
.. _convert-to-local-dev: | ||
|
||
Convert Official Image to an Atlas Local Dev Implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think the feature is being called "Local Atlas Deployment" in https://www.mongodb.com/docs/atlas/cli/current/atlas-cli-deploy-local/
Convert Official Image to an Atlas Local Dev Implementation | |
Convert Official Image to a Local Atlas Deployment |
@@ -432,3 +439,55 @@ directory: | |||
sudo dpkg -i mongosh.deb | |||
mongosh --version | |||
- run: mongosh 'mongodb://localhost/?directConnection=true' --eval 'show dbs' | |||
|
|||
|
|||
.. _convert-to-local-dev: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: It would be nice to link to the docker hub links, the mongo:8.0
links to https://hub.docker.com/_/mongo and our image to https://hub.docker.com/r/mongodb/mongodb-atlas-local
source/atlas-cli-deploy-docker.txt
Outdated
|
||
services: | ||
local_dev_atlas: | ||
image: mongodb/mongodb-atlas-local:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: you can use same mongodb version here as well
image: mongodb/mongodb-atlas-local:latest | |
image: mongodb/mongodb-atlas-local:8.0 |
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (mongodb#783) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
💔 Some backports could not be createdManual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…l image to local dev image (#783) (#787) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#788) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#789) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#790) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#792) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#793) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#795) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#796) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#798) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#799) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#801) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#802) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#797) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#800) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
…l image to local dev image (#783) (#791) * DOCSP-45301 -- Add checklist and examples for converting from official image to local dev image * DOCSP-45301 -- edit example yaml * DOCSP-45301 -- external review revisions * DOCSP-45301 -- copy review revisions * DOCSP-45301 -- external review revisions (cherry picked from commit 464319a)
Self-Review Checklist