Skip to content

Add Nano Server to the list #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

Add Nano Server to the list #1014

wants to merge 10 commits into from

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Nov 17, 2019

Description of Change

This PR should just create 2 new NativeAssets packages for Microsoft Nano Server.

Because Nano Server is really just Win32 without some features, you actually can just build it using the same code, but with a few extra args - basically a new #define SK_BUILD_FOR_NANOSERVER

.\bootstrapper.ps1 -t externals-windows --buildarch=x64 --additionalGnArgs="extra_cflags+=[''''-DSK_BUILD_FOR_NANOSERVER'''']"

all those extra single quotes (4 of them) are required to make sure powershell doesn't mess up the parameters.

TODO:

  • tests
  • some sort of verification like with NoDependencies for linux

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mattleibow
Copy link
Contributor Author

@mattleibow
Copy link
Contributor Author

This will be pulled in with #1040.

@mattleibow mattleibow closed this Dec 3, 2019
@mattleibow mattleibow deleted the dev/nano-server branch December 3, 2019 12:47
@mattleibow mattleibow added this to the v1.68.1.1 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Windows Nano Server
1 participant