Skip to content

MOBILE-4653 acceptance: Use LMS main branch again #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025
Merged

MOBILE-4653 acceptance: Use LMS main branch again #4466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ccf38
MOBILE-4653 acceptance: Use LMS main branch again
dpalou Jun 6, 2025
f69a36b
MOBILE-4653 core: Fix message not stored in cache for CoreWSError
dpalou Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/acceptance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ jobs:
run: moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
env:
DB: pgsql
MOODLE_BRANCH: ${{ github.event.inputs.moodle_branch || 'MOODLE_500_STABLE' }} # TODO: Use 'main' once MDL-85632 is fixed.
MOODLE_BRANCH: ${{ github.event.inputs.moodle_branch || 'main' }}
MOODLE_REPO: ${{ github.event.inputs.moodle_repository || 'https://github.com/moodle/moodle.git' }}
MOODLE_BEHAT_IONIC_WWWROOT: https://localhost:8001
MOODLE_BEHAT_DEFAULT_BROWSER: chrome
Expand Down
6 changes: 5 additions & 1 deletion src/core/classes/sites/authenticated-site.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,11 @@ export class CoreAuthenticatedSite extends CoreUnauthenticatedSite {

if (preSets.saveToCache) {
// Save the error instead of deleting the cache entry so the same content is displayed in offline.
this.saveToCache(method, data, error, preSets);
// Create a new error object when storing, otherwise the message is not stored with CoreWSError.
this.saveToCache(method, data, {
...error,
message: error.message,
}, preSets);
}

throw new CoreWSError(error);
Expand Down