-
Notifications
You must be signed in to change notification settings - Fork 113
feat(): add composite active users to usage reporting generator #7072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kik-kik
merged 7 commits into
main
from
feat/add-composite-active_users-to-usage_reporting-generator
Mar 12, 2025
Merged
feat(): add composite active users to usage reporting generator #7072
kik-kik
merged 7 commits into
main
from
feat/add-composite-active_users-to-usage_reporting-generator
Mar 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kik-kik
commented
Feb 20, 2025
sql_generators/usage_reporting/templates/usage_reporting_active_users.view.sql.jinja
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
kik-kik
commented
Feb 27, 2025
sql_generators/usage_reporting/templates/composite_active_users.view.sql.jinja
Outdated
Show resolved
Hide resolved
1ffad0a
to
6b2ef70
Compare
This comment has been minimized.
This comment has been minimized.
900c247
to
71e9459
Compare
This comment has been minimized.
This comment has been minimized.
71e9459
to
1d7c230
Compare
This comment has been minimized.
This comment has been minimized.
33fcd06
to
305fc19
Compare
This comment has been minimized.
This comment has been minimized.
af0cc1c
to
89a6c96
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f66248a
to
1143c0e
Compare
This comment has been minimized.
This comment has been minimized.
3a0e3be
to
39d5ad8
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7f9a6f3
to
e61fcc0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…he active_users view
424c648
to
f7011d5
Compare
Integration report for "fix: add first_seen_date to the usage_reporting_active_users view"
|
ogzillla
approved these changes
Mar 11, 2025
irrationalagent
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(): add composite active users to usage reporting generator
Will convert from draft PR once we agree on what the filter should be for the union.
blocked by: #7157