-
Notifications
You must be signed in to change notification settings - Fork 113
[DENG-8178]: create search_clients_daily_v9 table from glean #7358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ogzillla
wants to merge
9
commits into
main
Choose a base branch
from
DENG-8178-Build-a-new-Glean-based-equivalent-table-to-replace-search_clients_daily_v8
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DENG-8178]: create search_clients_daily_v9 table from glean #7358
ogzillla
wants to merge
9
commits into
main
from
DENG-8178-Build-a-new-Glean-based-equivalent-table-to-replace-search_clients_daily_v8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
We need the Glean equivalents for the following fields:
|
These last three I documented here: https://mozilla-hub.atlassian.net/browse/DENG-7980?focusedCommentId=1050278 |
This comment has been minimized.
This comment has been minimized.
…Build-a-new-Glean-based-equivalent-table-to-replace-search_clients_daily_v8
This comment has been minimized.
This comment has been minimized.
…Build-a-new-Glean-based-equivalent-table-to-replace-search_clients_daily_v8
This comment has been minimized.
This comment has been minimized.
ogzillla
commented
May 7, 2025
distribution_id, | ||
locale, | ||
user_pref_browser_search_region, | ||
-- search_cohort, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skahmann3 @betling is this field still needed? It's currently derived thus in Legacy telemetry
…Build-a-new-Glean-based-equivalent-table-to-replace-search_clients_daily_v8
Integration report for "DENG-8178: drop firefox filter"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building the
search_clients_daily_v9
from Glean. Previous versions were built from Legacy Telemetry.Related Tickets & Documents
JIRA
Reviewer, please follow this checklist