Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

update LMDB to latest stable release version 0.9.23 #26

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

mykmelez
Copy link

This'll also require publishing lmdb-rkv-sys for the first time (until now we've been relying on lmdb-sys from the upstream lmdb-rs project).

@mykmelez mykmelez requested a review from ncloudioj January 29, 2019 00:30
@mykmelez
Copy link
Author

@ncloudioj I'm not making any code changes here, just revving the version of LMDB. But it'd still be worth a sanity-check from you that this is a reasonable approach to keeping up with upstream changes to LMDB. (I originally expected to periodically merge changes from the upstream lmdb-rs project, but it doesn't seem to be active anymore, so I think we're going to need to maintain our own copy of LMDB.)

Copy link
Member

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think LMDB is heading towards the 1.0 release, so its development seems to be slowing down a bit lately.

@ncloudioj ncloudioj merged commit 4202c59 into mozilla:master Jan 29, 2019
@mykmelez
Copy link
Author

I think LMDB is heading towards the 1.0 release, so its development seems to be slowing down a bit lately.

Woot! I #23 I suggest maintaining a branch of lmdb-rs that tracks the master branch of LMDB, which is where version 1.0 is being developed. Might be interesting, although it isn't a priority for me at this point.

@ncloudioj
Copy link
Member

ncloudioj commented Jan 29, 2019

Don't be over-optimistic!!! I've been waiting for the 1.0 release since 0.9.7 (released 4 maybe 5 years ago), they go crazy about the software quality. Hopefully my beard isn't grey when 1.0 hits the road :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants