[Progress] Add Progress.Label and locale prop
#1666
Merged
+460
−415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
the
component: progress
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mj12albert
changed the title
Progress.LabelProgress.Label and locale prop
mj12albert
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
mj12albert
force-pushed
the
feat/progress-label
branch
from
ccad4a5 to
df6f1ca
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
feat/progress-label
branch
from
df6f1ca to
e1d106a
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
feat/progress-label
branch
from
e1d106a to
cf07145
Compare
mj12albert
force-pushed
the
feat/progress-label
branch
from
cf07145 to
6ba0a11
Compare
mj12albert
force-pushed
the
feat/progress-label
branch
2 times, most recently
from
00001fb to
0feb51f
Compare
github-actions
bot
added
the
PR: out-of-date
mj12albert
force-pushed
the
feat/progress-label
branch
from
0feb51f to
e5ac57f
Compare
github-actions
bot
removed
the
PR: out-of-date
mj12albert
force-pushed
the
feat/progress-label
branch
from
1f6ee54 to
66f9344
Compare
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
atomiks
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://deploy-preview-1666--base-ui.netlify.app/react/components/progress
Dropped the
getAriaLabelprop asProgress.Labelshould be used to provide an accessible nameAlso:
localeprop that can be used withformatto match [NumberField] Addlocaleprop #1488minandmaxfrom state: [meter] Add Meter component #1435 (comment)useRenderElementCloses #1201