Skip to content

[test] Add more conformance tests for popups #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

[test] Add more conformance tests for popups #1693

merged 4 commits into from
Apr 15, 2025

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Apr 9, 2025 •
edited
Loading

Adds tests for #1552

The underlying issue is fixed in floating-ui

@mj12albert mj12albert added component: select This is the name of the generic UI component, not the React module! component: menu This is the name of the generic UI component, not the React module! component: popover This is the name of the generic UI component, not the React module! labels Apr 9, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 9, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 49bc197
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67fdf8a79d94eb0008869a98
😎 Deploy Preview https://deploy-preview-1693--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mj12albert mj12albert force-pushed the fix/popups-id-prop branch from 6b1d3c4 to ca89bb3 Compare April 9, 2025 11:48
@atomiks
Copy link
Contributor

atomiks commented Apr 10, 2025

@mj12albert should be fixed automatically now in the latest version if you upgrade to @floating-ui/react@0.27.7, those new tests should pass

@mj12albert mj12albert changed the title [Popups] Fix aria-controls with a custom popup id [Popups] Add more conformance tests for popups Apr 11, 2025
@mj12albert mj12albert changed the title [Popups] Add more conformance tests for popups [test] Add more conformance tests for popups Apr 11, 2025
@mj12albert mj12albert force-pushed the fix/popups-id-prop branch 2 times, most recently from 7fb989c to 549fba4 Compare April 11, 2025 16:31
@mj12albert mj12albert marked this pull request as ready for review April 11, 2025 17:59
@mj12albert mj12albert merged commit bff061d into mui:master Apr 15, 2025
22 checks passed
@mj12albert mj12albert deleted the fix/popups-id-prop branch April 15, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomiks atomiks

@colmtuite colmtuite

@michaldudak michaldudak

Assignees
No one assigned
Labels
component: menu This is the name of the generic UI component, not the React module! component: popover This is the name of the generic UI component, not the React module! component: select This is the name of the generic UI component, not the React module! test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mj12albert @atomiks