Skip to content

[docs][Dialog] Remove deprecated props usage in demos #45923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 15, 2025

@sai6855 sai6855 added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Apr 15, 2025
@mui-bot
Copy link

mui-bot commented Apr 15, 2025

Netlify deploy preview

https://deploy-preview-45923--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8874b8e

@sai6855 sai6855 requested a review from siriwatknp April 15, 2025 14:32
@sai6855 sai6855 added v6.x needs cherry-pick The PR should be cherry-picked to master after merge labels Apr 15, 2025
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sai6855 sai6855 merged commit 8959ade into mui:master Apr 16, 2025
24 checks passed
Copy link

Cherry-pick PRs will be created targeting branches: v6.x

@BenGedi
Copy link

BenGedi commented Apr 16, 2025

@sai6855 i still see the deprecated syntax in the your doc, also why you are still using forwardRef since it is also deprecated after react 19?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation needs cherry-pick The PR should be cherry-picked to master after merge package: material-ui Specific to @mui/material v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] update Dialog transition example, TransitionComponent is deprecated
4 participants