Skip to content

Don't assume auto-handle; don't send self-remove #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: add-more-functionality
Choose a base branch
from

Conversation

bifurcation
Copy link

The current script generator makes two assumptions that are not necessarily true:

  1. That a client automatically cues any proposals that it creates for commit, and thus doesn't need to be instructed to commit them
  2. That a client can gracefully handle a commit that removes the client

This PR makes the corresponding changes to scenario generation to accommodate the case where these are not true:

  1. All proposals are explicitly signaled in byReference, including those created by the committer
  2. A commit that removes a member is not sent to that member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant