Streaming fix #4201
Open
Streaming fix #4201
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FileEX
approved these changes
May 6, 2025
Nico8340
approved these changes
May 6, 2025
|
Thanks! This will be merged in one of the next rounds of builds that are intended for extensive testing. Streamer is always a sensitive part to modify, as we also just got reminded of. (Please don't merge it before i do) |
|
I've requested a review from TheNormalnij as well, he has experience with streamer stuff. |
TheNormalnij
reviewed
May 8, 2025
| @@ -4041,6 +4041,13 @@ void CClientPed::ReCreateGameEntity() | |||
|
|
|||
| void CClientPed::ModelRequestCallback(CModelInfo* pModelInfo) | |||
| { | |||
| // The model loading may take a while and there's a chance of ped being moved to other dimension. | |||
| if (!IsVisibleInAllDimensions() && GetDimension() != m_pStreamer->GetDimension()) | |||
There was a problem hiding this comment.
if (!ShouldBeVisibleInCurrentDimension())And you can keep m_pStreamer private
|
The logic looks correct |
|
Up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reimplementation of #4184(thanks to @FileEX) and includes fix #4198(thanks to @Nico8340) with changes which make the whole thing a little bit more performant(it prevents models from loading instead of unloading them straight after the load).