editor: fixes, random rotation func, getCurrentMapName func, updated scale func #633
+318
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hex codes from player names
|
Thank you for the video that summarizes everything! I'll take a look at the code |
This reverts commit e4b6c06.
|
Reverted one change I got made aware of by @q8X , thanks |
|
most recent change avoids this bug in the editor: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #589, #603 and also some other smaller issues, like unnecessary outputDebugMessages.
There was also a weird camera bug that only happened whenver you created a ped and or marker which was caused due of how the elementcreation got handled -> see elementcreation.lua
I've also revamped the scale functionality I implemented with #604 which mainly removes needless special handling for scale and also now only returns one value when getObjectScale() is called.
Further I moved the settings into an advanced tab, as it would have gotten to cluttered with new functionality of the rotation stuff and looks cleaner in general.
To add to that there where also some issues with outside resources, mainly mtp by @chris1384 where the scale property would not update correctly.
The settings.xml now also gets read properly and adds any values it might be missing.
Before this change you wouldn't be able to use the editor anymore if any value/setting was missing.
There was also an incorrect implementation of the doubleside property, everytime you copied and object it would set it to true by default even though it should be false.
I'm probably missing some smaller stuff that got changed in the process.
See video below. Sorry for the sound quality:
https://www.youtube.com/watch?v=BQghNXO8H4g
Edit:
One more thing I wanted to mention, we always pass creation parameters for rotation from the client to the server now this might or might not fix one of the weird rotation bugs that can happen
https://www.youtube.com/watch?v=UXMcEXorgiM