-
Notifications
You must be signed in to change notification settings - Fork 161
fix: check that frozen.build exists before trying to access it #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
If there is a compilation where frozen.build is not generated for some reason, then the check here would fail and throw an exception: Could not freeze FILE_NAME: Cannot read property 'hash' of undefined We check to see if the build exists and then fall through to regenerate if it does not.
@mzgoddard Can we have this merged? |
@mzgoddard Could you please, please review this PR and merge it? This problem is really a showstopper for us. |
Any update on merging this in? |
bump |
Can anyone look at the travis tests, see why they are not passing? |
So the tests aren't passing because TL;DR this looks perfectly safe to merge, with or without fixing the liner errors that are already in master anyway. |
m |
If there is a compilation where frozen.build is not generated for some reason then the check here would fail and throw an exception:
Added check to see if the build exists, and then fall through to regenerate if it does not.