Skip to content

release 0.8.7 #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

release 0.8.7 #176

wants to merge 2 commits into from

Conversation

nagisa
Copy link
Owner

@nagisa nagisa commented Apr 26, 2025

No description provided.

@nagisa nagisa force-pushed the nagisa/release-0.8.7 branch from d31de0f to bf20bc0 Compare April 26, 2025 00:44
@Berrysoft
Copy link
Contributor

Consider removing this line?

- run: echo "c:/msys64/bin" | Out-File -FilePath $env:GITHUB_PATH -Append

I ran the tests on my own device and succeeded with nightly rustc and x86_64-pc-windows-gnu target. I guess it's the environment's problem.

@nagisa
Copy link
Owner Author

nagisa commented Apr 29, 2025

I mean yeah, but at the same time this used to work (and continues to work with 1.63 matrix) so something is not right here :) I don't think this should be buried entirely…

@Berrysoft
Copy link
Contributor

I suggested so because I guessed it was the MSYS2 linker being called mistakenly, instead of the mingw linker.

@Berrysoft
Copy link
Contributor

Berrysoft commented Apr 29, 2025

Oh, one thing I think I should point out: if location is not specified in msys2/setup-msys2 action, the location of msys2 is NOT C:\msys64. The one in C:\msys64 is prepared by the image.
Reference: https://github.com/msys2/setup-msys2?tab=readme-ov-file#msys2-location

Therefore I think the MSYS2 CI used is not the latest version. That might be the reason of failure.

@Berrysoft
Copy link
Contributor

Hi @nagisa , would you consider my comments about using the correct path of MSYS2? It's really weird though...

@nagisa
Copy link
Owner Author

nagisa commented May 8, 2025

Well, I'll look into it but no promises that I'll get to this soon. If this is time sensitive for you, consider picking up this branch and making a new PR.

@Berrysoft Berrysoft mentioned this pull request May 8, 2025
@Berrysoft
Copy link
Contributor

OK, I've opened #177 and will try to fix CI there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants