-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for linking against wolfSSL provided by wolfssl-sys #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Workflow Status ReportGenerated for commit 9af4237 on Tue Mar 4 15:01:48 UTC 2025. In case of failure, clippy warnings and rustfmt changes (if any) will be indicated as CI check warnings in the file comparison view. Documentation: Read Online Download Coverage Report: Read Online Download Note: Online versions of documentation and coverage reports may not be available indefinitely, especially after the pull request was merged. Code Coverage ReportCoverage target is 80%. Expand to view coverage statistics
Total coverage: 54.24% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just stumbled upon two tiny spots, otherwise LGTM :)
@@ -143,7 +147,8 @@ dtls-rpk = ["dtls"] | |||
[dependencies] | |||
openssl-sys = { version = "^0.9.74", optional = true } | |||
mbedtls-sys-auto = { version = "^2.26", optional = true } | |||
tinydtls-sys = { version = "^0.2.0", default-features = false, optional = true } | |||
wolfssl-sys = { version = "2.0.0", git = "https://github.com/namib-project/wolfssl-rs.git", branch = "add_sys_cargo_metadata", optional = true, features = ["aesccm", "hmac", "psk", "opensslall", "ex_data", "alpn", "dh"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this comment here to make sure that we don't merge this until the required changes to wolfssl-sys
have been upstreamed.
This PR allows the vendored version of
libcoap
to link against the version of wolfSSL that is used by thewolfssl-sys
crate.This change required some modifications to
wolfssl-sys
in order to expose the library paths to us and enable features necessary for libcoap, which is why it currently uses our own fork ofwolfssl-sys
.Closes #29.