Only build artifact on ready-to-merge label #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Alternative to #748
Description
To avoid using the less secure pull_request_target trigger, we can just avoid building the CircleCi preview.
The idea is that when reviewing, you would do the bot trigger to build the needed preview. The ready-to-merge build would just be there to verify that a full build doesn't fail.
Note: because a reusable action is used, it will be triggered from the fork, but that should be ok as long as the fork branch is up to date with napari/docs
main, which is easy to ensure with the update button in PRs.