Skip to content

Add support for Node-specific TLS options #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Conversation

aricart
Copy link
Member

@aricart aricart commented Apr 3, 2025

Introduced NodeTlsOptions and NodeConnectionOptions types to handle Node.js-specific TLS configuration rejectUnauthorized. Updated transport-node's connect() function and related logic to use the new type, and added a relevant test case for TLS behavior.

Introduced `NodeTlsOptions` and `NodeConnectionOptions` types to handle Node.js-specific TLS configurations, like `rejectUnauthorized`. Updated `connect` function and related logic to support these new options, and added a relevant test case for TLS behavior.

Signed-off-by: Alberto Ricart <[email protected]>
Signed-off-by: Alberto Ricart <[email protected]>
Copy link

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit a378523 into main Apr 4, 2025
23 checks passed
@aricart aricart deleted the reject-unauthorized branch April 4, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants