feat(jetstream): support for pedantic mode in consumer creation #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a `pedantic` option in `ConsumerApiOptions` to ensure stricter validation of consumer configuration during creation. Updated the `add` method in `jsmconsumer_api.ts` to handle this option, and added a test case to validate pedantic behavior. This enhances flexibility while enforcing stricter checks when needed. Note the original API allowed for an optional action (a string), now it also allows a ConsumerApiOptions object that allows setting the action and whether it should be pedantic. Signed-off-by: Alberto Ricart <[email protected]>
aricart
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a
pedanticoption inConsumerApiOptionsto ensure stricter validation of consumer configuration during creation. Updated theaddmethod injsmconsumer_api.tsto handle this option, and added a test case to validate pedantic behavior. This enhances flexibility while enforcing stricter checks when needed.Note the original API allowed for an optional action (a string), now it also allows a ConsumerApiOptions object that allows setting the action and whether it should be pedantic.