Skip to content

Fix proxy with TLS scenario with SocketConnectionFactory #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025

Conversation

wolfkor
Copy link
Contributor

@wolfkor wolfkor commented Apr 13, 2025

@mtmk mtmk changed the title fix proxy with TLS scenario ba SocketConnectionFactory (#802) fix proxy with TLS scenario with SocketConnectionFactory Apr 13, 2025
Copy link
Member

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @wolfkor

@mtmk mtmk requested a review from caleblloyd April 13, 2025 18:50
@mtmk mtmk changed the title fix proxy with TLS scenario with SocketConnectionFactory Fix proxy with TLS scenario with SocketConnectionFactory Apr 13, 2025
@mtmk mtmk merged commit 30598aa into nats-io:main Apr 15, 2025
17 checks passed
mtmk added a commit that referenced this pull request Apr 15, 2025
mtmk added a commit that referenced this pull request Apr 15, 2025
mtmk pushed a commit that referenced this pull request Apr 15, 2025
* fix proxy with TLS scenario ba SocketConnectionFactory (#802) (#804)

* init (#826)

* socket connection factory

Signed-off-by: Caleb Lloyd <[email protected]>

* standardize ConnectAsync

Signed-off-by: Caleb Lloyd <[email protected]>

* clean up INatsSocketConnection

Signed-off-by: Caleb Lloyd <[email protected]>

* improve doc

Signed-off-by: Caleb Lloyd <[email protected]>

---------

Signed-off-by: Caleb Lloyd <[email protected]>
Co-authored-by: wolfkor <[email protected]>
@wolfkor wolfkor deleted the fix-802 branch April 15, 2025 11:49
mtmk added a commit that referenced this pull request Apr 16, 2025
* Stopped testing with net6.0 (#821)
* Update JetStream models (#832)
* Add direct request-reply (#829)
* Socket Connection Factory (#828)
* Fix proxy with TLS scenario with SocketConnectionFactory (#826)
* Make NatsJSConstants public (#825)
* Use Stopwatch in PingCommand for more precise timing (#827)
* Fix netstandard bugs and tidy up tests (#817)
@mtmk mtmk mentioned this pull request Apr 16, 2025
mtmk added a commit that referenced this pull request Apr 16, 2025
* Stopped testing with net6.0 (#821)
* Update JetStream models (#832)
* Add direct request-reply (#829)
* Socket Connection Factory (#828)
* Fix proxy with TLS scenario with SocketConnectionFactory (#826)
* Make NatsJSConstants public (#825)
* Use Stopwatch in PingCommand for more precise timing (#827)
* Fix netstandard bugs and tidy up tests (#817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communication with TLS bus behind proxy results in SslPolicyErrors.RemoteCertificateNameMismatch
2 participants