Skip to content

Add README, .editorconfig; update issues links #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cxw42
Copy link

@cxw42 cxw42 commented Apr 22, 2019

  • Added a README.md converted from script/perlver, for the sake of
    the GitHub repo.
  • Added the GitHub issues link alongside the the CPAN issues link
  • Added a .editorconfig file to help with consistency in formatting.
    As far as I can tell from the source, it's Unix linefeeds, tab
    indents, and four-space tabs. I got the four-space tabs from
    lib/Perl/MinimumVersion.pm:459--460, which don't indent correctly
    with two-space tabs. Of course, I could be wrong!

@cxw42 cxw42 changed the title Added README, .editorconfig; updated issues links Add README, .editorconfig; update issues links Apr 22, 2019
@Grinnz Grinnz mentioned this pull request Apr 5, 2021
@zmughal
Copy link

zmughal commented May 16, 2023

The README.md is no longer needed as there is a generated README.pod via #23. The rest of the changes look fine to me, but will need @neilb's input.

cxw42 and others added 2 commits May 27, 2023 11:52
- Added a .editorconfig file to help with consistency in formatting.
  As far as I can tell from the source, it's Unix linefeeds, tab
  indents, and four-space tabs.  I got the four-space tabs from
  lib/Perl/MinimumVersion.pm:459--460: those lines don't indent
  correctly with two-space tabs.
- In lib/Perl/MinimumVersion.pm, change the leading spaces to
  leading tabs for consistency.
- Added the GitHub issues link alongside the the CPAN issues link
- Updated copyright dates
- Synced the author and copyright information in lib/ and script/
@cxw42
Copy link
Author

cxw42 commented May 27, 2023

@zmughal Thanks for the update! I have modified the PR.

  • I no longer create a README
  • I discovered MinimumVersion.pm had mixed leading indents, so updated it to use all tabs.
  • I updated the copyright dates and made sure they were in sync between MinimumVersion.pm and perlver.

dzil regenerate and dzil test pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants