Allow to sign transaction without relaying #3934
Open
+54
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
reviewed
May 8, 2025
| @@ -29,6 +31,7 @@ public static JObject TransactionToJson(Transaction tx, ProtocolSettings setting | |||
| JObject json = tx.ToJson(settings); | |||
| json["sysfee"] = tx.SystemFee.ToString(); | |||
| json["netfee"] = tx.NetworkFee.ToString(); | |||
| json["raw"] = Convert.ToBase64String(tx.ToArray()); | |||
There was a problem hiding this comment.
NACK. This changes the behavior of existing APIs for no real reason.
Wi1l-B0t
reviewed
May 8, 2025
| @@ -306,7 +307,13 @@ protected internal virtual JToken SendFrom(JArray _params) | |||
| tx.NetworkFee = calFee; | |||
| } | |||
| (tx.NetworkFee <= settings.MaxFee).True_Or(RpcError.WalletFeeLimit); | |||
| return SignAndRelay(snapshot, tx); | |||
| if (relay) { | |||
|
Why add this ? Can you add more details? |
|
The information is clear, but maybe it's better to add a new endPoint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow to sign transaction without relaying to the network
Suitable for two-phase transaction sending
Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: