Skip to content

safekeeper: add enable_tls_wall_service_api #11520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DimasKovas
Copy link
Member

Problem

Safekeeper doesn't use TLS in wall service

Summary of changes

  • Add enable_tls_wall_service_api option to safekeeper's cmd arguments
  • Propagate tls_server_config to wall_service if the option is enabled
  • Create BACKGROUND_RUNTIME for small background tasks and offload SSL certificate reloader to it.

No integration tests for now because support from compute side is required: https://github.com/neondatabase/cloud/issues/25823

@DimasKovas DimasKovas requested a review from a team as a code owner April 10, 2025 11:33
@DimasKovas DimasKovas requested review from VladLazar and Copilot and removed request for VladLazar April 10, 2025 11:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@DimasKovas DimasKovas requested a review from VladLazar April 10, 2025 11:33
Copy link

github-actions bot commented Apr 10, 2025

8232 tests run: 7794 passed, 0 failed, 438 skipped (full report)


Flaky tests (6)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 33.2% (8942 of 26969 functions)
  • lines: 48.8% (77113 of 157861 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
37bd82a at 2025-04-11T14:33:32.995Z :recycle:

@DimasKovas DimasKovas requested a review from Copilot April 11, 2025 09:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

safekeeper/tests/walproposer_sim/safekeeper.rs:188

  • Consider adding tests for behavior when enable_tls_wall_service_api is enabled to ensure new TLS functionality is exercised.
        enable_tls_wall_service_api: false,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant