-
Notifications
You must be signed in to change notification settings - Fork 530
safekeeper: add enable_tls_wall_service_api #11520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
8232 tests run: 7794 passed, 0 failed, 438 skipped (full report)Flaky tests (6)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
37bd82a at 2025-04-11T14:33:32.995Z :recycle: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
safekeeper/tests/walproposer_sim/safekeeper.rs:188
- Consider adding tests for behavior when enable_tls_wall_service_api is enabled to ensure new TLS functionality is exercised.
enable_tls_wall_service_api: false,
Problem
Safekeeper doesn't use TLS in wall service
Summary of changes
enable_tls_wall_service_api
option to safekeeper's cmd argumentstls_server_config
towall_service
if the option is enabledBACKGROUND_RUNTIME
for small background tasks and offload SSL certificate reloader to it.No integration tests for now because support from compute side is required: https://github.com/neondatabase/cloud/issues/25823