Refactor struct xrdp_client_info (rework) #3492
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The struct 'struct xorgxrdp_client_info' is factored out of 'struct xrdp_client_info'. This represents the items which are required to be passed to xorgxrdp.
Some assignments and copies are replaced with a single equivalent structure assigment to improve readability.
Use some variable substitutions and reformatting to reduce some source lines to <= 80 characters to improve readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #3490
The struct 'struct xorgxrdp_client_info' is factored out of 'struct xrdp_client_info'. This represents the items which are required to be passed to xorgxrdp.
This PR also requires a small change to xorgxrdp (neutrinolabs/xorgxrdp#384).
Is
puba good name for the new member ofstruct xrdp_client_info? There's probably a better one.Edit: Because line lengths of some lines are increased because of the need for a
pubmember to access some data, I've added three commits to tidy up some source lines more than 80 characters in length. These commits should not change any functionality and could stand on their own.