Skip to content

Fix Datastore Span Attributes #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025
Merged

Fix Datastore Span Attributes #1346

merged 4 commits into from
Apr 9, 2025

Conversation

TimPansino
Copy link
Contributor

Overview

  • Correct attributes on datastore spans to match spec.
  • Add additional testing to validate the new attributes are attached, and properly truncated.

@TimPansino TimPansino requested a review from a team as a code owner April 3, 2025 19:09
Copy link

github-actions bot commented Apr 3, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 4 0 0 0.46s
✅ MARKDOWN markdownlint 7 0 0 0 0.9s
✅ MARKDOWN markdown-link-check 7 0 0 17.75s
✅ PYTHON ruff 893 0 0 0 0.56s
✅ PYTHON ruff-format 893 0 0 0 0.35s
✅ YAML prettier 10 0 0 0 1.15s
✅ YAML v8r 10 0 0 5.86s
✅ YAML yamllint 10 0 0 0.53s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (7f7a878) to head (edf60fb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1346   +/-   ##
=======================================
  Coverage   81.48%   81.49%           
=======================================
  Files         204      204           
  Lines       22823    22824    +1     
  Branches     3618     3618           
=======================================
+ Hits        18598    18601    +3     
  Misses       3013     3013           
+ Partials     1212     1210    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some concerns about moving the datastore specific attributes into the base class.

@hmstepanek hmstepanek merged commit 6c10093 into main Apr 9, 2025
56 of 57 checks passed
@hmstepanek hmstepanek deleted the fix-datastore-spans branch April 9, 2025 21:32
@hmstepanek hmstepanek added this to the v10.9.0 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants