Skip to content

Async Elasticsearch Instrumentation #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 24, 2025
Merged

Async Elasticsearch Instrumentation #1362

merged 32 commits into from
Apr 24, 2025

Conversation

TimPansino
Copy link
Contributor

Overview

@TimPansino TimPansino requested a review from a team as a code owner April 21, 2025 16:11
Copy link

github-actions bot commented Apr 21, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.46s
✅ MARKDOWN markdownlint 7 0 0 0 0.91s
✅ MARKDOWN markdown-link-check 7 0 0 16.15s
✅ PYTHON ruff 901 0 0 0 0.61s
✅ PYTHON ruff-format 901 0 0 0 0.33s
✅ YAML prettier 13 0 0 0 1.13s
✅ YAML v8r 13 0 0 7.39s
✅ YAML yamllint 13 0 0 0.58s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2025

Codecov Report

Attention: Patch coverage is 96.77419% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.00%. Comparing base (a330873) to head (8267ae1).

Files with missing lines Patch % Lines
newrelic/hooks/datastore_elasticsearch.py 96.39% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
+ Coverage   79.90%   80.00%   +0.09%     
==========================================
  Files         204      204              
  Lines       22842    22952     +110     
  Branches     3618     3639      +21     
==========================================
+ Hits        18253    18363     +110     
  Misses       3392     3392              
  Partials     1197     1197              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TimPansino
Copy link
Contributor Author

@fagnerzulin That was more rabbit holes than I was expecting but I believe I've fixed every last issue with this, so it should be out in the next release.

@mergify mergify bot removed the tests-failing label Apr 21, 2025
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple things-otherwise looks good.

@TimPansino TimPansino requested a review from hmstepanek April 24, 2025 18:23
@hmstepanek hmstepanek merged commit 68da5b7 into main Apr 24, 2025
57 of 59 checks passed
@hmstepanek hmstepanek deleted the feat-async-elasticsearch branch April 24, 2025 21:07
@mergify mergify bot removed the tests-failing label Apr 24, 2025
@TimPansino TimPansino added this to the v10.10.0 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants