BugFix - Filter OCFileList #14809
Merged
BugFix - Filter OCFileList #14809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
commented
Apr 22, 2025
| @@ -858,12 +859,18 @@ public void swapDirectory( | |||
| mFiles = updatedStorageManager.filter(currentDirectory, OCFileFilterType.Favorite); | |||
| } | |||
|
|
|||
| // Filter out temp files from the list to prevent duplication | |||
| mFiles = OCFileExtensionsKt.filterTempFilter(mFiles); | |||
There was a problem hiding this comment.
Temp files used for E2EE and swapDirectory gets called multiple times with same data. These issues will be handled in different PR.
ZetaTom
previously requested changes
Apr 23, 2025
app/src/main/java/com/nextcloud/utils/extensions/OCFileExtensions.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/utils/extensions/OCFileExtensions.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…ons.kt Co-authored-by: Tom <[email protected]> Signed-off-by: Alper Öztürk <[email protected]>
alperozturk96
force-pushed
the
bugfix/filter-oc-file-list-adapter-items-correctly
branch
from
e8af738 to
31a25c4
Compare
Signed-off-by: alperozturk <[email protected]>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14809.apk |
ZetaTom
approved these changes
Apr 28, 2025
alperozturk96
deleted the
bugfix/filter-oc-file-list-adapter-items-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce?
Issue Demo
Screen.Recording.2025-04-22.at.09.37.01.mp4
Fix
fix.mp4