perf: skip message skeleton if it is cached #10750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
requested review from
ChristophWurst,
kesselb and
GretaD
as code owners
|
@st3iny please rebase, linter, and dco ;) |
st3iny
force-pushed
the
perf/message-skeleton
branch
from
3f66b12 to
fa14e2c
Compare
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
perf/message-skeleton
branch
from
fa14e2c to
cd2603d
Compare
kesselb
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10749
Cache messages in the frontend directly. Only show the skeleton if message is not yet cached.
I also delayed the skeleton animation by 200 milliseconds as we also do HTTP level caching. To prevent flickering in case the message is not cached in the frontend but by the browser.
Screencasts
No browser cache + extremely slow connection
2025-02-25.21-33-00.mp4
Browser cache + normal connection (localhost)
2025-02-25.21-35-27.mp4