Skip to content

feat: split envelopes by time of arrival #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jun 12, 2025

fixes #11057

to do

  • do not show an empty section

@GretaD GretaD self-assigned this Jun 12, 2025
@ChristophWurst
Copy link
Member

For reactivity: would it make sense to maintain the brackets in Pinia? Brackets relative to current time are probably not reactive. But if we commit the timestamp to Pinia, e.g. at every synchronization, and re-evaluate, it should be fine.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a problem with an empty view initially. When the app loads there are no envelopes at first. Fetching initial envelopes is handled inside Mailbox.vue which is not rendered as there are no envelopes initially (and no groups as a consequence). As a result, no envelopes will be fetched and rendered until the first background sync hits.

My suggestions:

  1. Move the sections/groups from MailboxThread.vue into Mailbox.vue.
  2. Move some of the envelope fetching logic from Mailbox.vue to MailboxThread.vue (have a look at mounted(), loadEnvelopes() and prefetchOtherMailboxes() in Mailbox.vue).

In any case, you should rebase against latest origin/main soon as I implemented a lot of changes to the sync logic in Mailbox.vue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thread list separators depending on sort attribute
3 participants