-
Notifications
You must be signed in to change notification settings - Fork 271
feat: split envelopes by time of arrival #11264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
Signed-off-by: greta <[email protected]>
For reactivity: would it make sense to maintain the brackets in Pinia? Brackets relative to current time are probably not reactive. But if we commit the timestamp to Pinia, e.g. at every synchronization, and re-evaluate, it should be fine. |
Signed-off-by: greta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a problem with an empty view initially. When the app loads there are no envelopes at first. Fetching initial envelopes is handled inside Mailbox.vue
which is not rendered as there are no envelopes initially (and no groups as a consequence). As a result, no envelopes will be fetched and rendered until the first background sync hits.
My suggestions:
- Move the sections/groups from
MailboxThread.vue
intoMailbox.vue
. - Move some of the envelope fetching logic from
Mailbox.vue
toMailboxThread.vue
(have a look atmounted()
,loadEnvelopes()
andprefetchOtherMailboxes()
inMailbox.vue
).
In any case, you should rebase against latest origin/main
soon as I implemented a lot of changes to the sync logic in Mailbox.vue
.
fixes #11057
to do