Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New executor for Fujitsu Technical Computing Suite (TCS) #5928

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

exthnet
Copy link

@exthnet exthnet commented Mar 27, 2025

This is a new Executor for Fujitsu Technical Computing Suite (TCS).

Some supercomputers build by Fujitsu are operated (mainly in Japan).
Most of they use Technical Computing Suite (TCS) job management system, they are not supported by current Nextflow.

Therefore, I wrote new Executor citing existing executors.
We tested simple jobs and confirmed the correct behaviors on on Fugaku (Riken), Flow (Naogya Univ.), and Genkai (Kyushu Univ.) supercomputers.

Note that I am not familiar with all the features of Nextflow, so there may be some lack of implementation.

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 36c82f6
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67ee175a87c14600083e6c45

Copy link
Member

@pditommaso pditommaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution. Please consider adding some unit tests. You can reference to other executors for some examples. Also please sign your commits as example in the contributing docs

Comment on lines 16 to 35
I referred to the other executors groovy implementations.
Resource requests and other job characteristics can be controlled via the following process directives:
- time
- clusterOptions
queue (resource group), cpu, node, and other options should be indicated by clusterOptions.
This is because they depend on target systems (required options are not the same) and can be controlled by "-L" options in arguments of pjsub command.

example of nextflow.config on Genkai (Kyushu University)
process {
executor = 'tcs'
time = '00:30:00'
clusterOptions = '-L rscgrp=a-batch -L vnode-core=4'
}

example of nextflow.config on Flow (Nagoya University)
process {
executor = 'tcs'
time = '00:30:00'
clusterOptions = '-L rscunit=cx -L rscgrp=cx-share -L gpu=1'
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the docs. Can you create a new section in docs/executor.md? You can use existing sections as a template

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to the docs. Can you create a new section in docs/executor.md? You can use existing sections as a template

Thank you, I'm updating the documents.

@bentsherman bentsherman linked an issue Mar 28, 2025 that may be closed by this pull request
@exthnet exthnet requested a review from a team as a code owner April 3, 2025 04:49
@exthnet
Copy link
Author

exthnet commented Apr 3, 2025

Thanks a lot for this contribution. Please consider adding some unit tests. You can reference to other executors for some examples. Also please sign your commits as example in the contributing docs

Thanks for the advice. I'll try to add unit tests and add sign.

Signed-off-by: Satoshi Ohshima <[email protected]>>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New feature: TCS Executor (for Supercomputers of Fujitsu)
3 participants