Skip to content

Translate to Korean the main index page. #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 4, 2025

Conversation

JaeungJayJang
Copy link
Contributor

@JaeungJayJang JaeungJayJang commented Mar 23, 2025

pages translated to Korean:

  • docs/index.md
  • docs/envsetup/index.md
  • docs/envsetup/01_setup.md
  • docs/envsetup/02_local.md

Copy link

netlify bot commented Mar 23, 2025

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit 0ed4027
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/68123b6cc79f510008b8e98f
😎 Deploy Preview https://deploy-preview-578--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JaeungJayJang
Copy link
Contributor Author

Hello! I saw that Korean is not currently on the list of the available language and wanted to chime in and add pages in Korean. I followed the Translating.md guide but let me know if there's anything that is further needed for this to be merged. @ewels Could you provide any feedback?

Additionally, I would like to know what would be the best approach to submit multiple page translations. Should I create PR for each page, or can I keep pushing the change into this PR?

@ewels
Copy link
Member

ewels commented Apr 10, 2025

Amazing stuff @JaeungJayJang!

I'll defer to @mribeirodantas on this, as he's led the charge for translations of the training material in the past 🙏🏻

@vdauwera
Copy link
Collaborator

vdauwera commented Apr 14, 2025

Hi @JaeungJayJang, thank you so much for getting this started!

This poses a new challenge for us as far as reviewing the material is concerned, since we don't have anyone on the team who speaks/reads Korean, so here's what I propose.

  1. I've used some AI translation tools to do an overall check, which tells me the content and tone of your translation are consistent with the original (which is awesome).

  2. If possible, I'd like to ask you to have one of your colleagues peer-review your translations, just to have a second pair of human eyes to catch any errors that the AI might not recognize.

If that works for you, please update your branch and let us know when you've had your colleague do the review, and we will merge this into the training repository.

If we have community members who later flag issues or suggest improvements, can we ask you to help us review and make the relevant changes?

As for translating other pages: please open new PRs for each course; so for example if you choose to translate the 'Hello Nextflow' course, we would prefer to have that in its own PR. That way we can release material bit by bit, and we avoid having very large PRs that are difficult to manage.

Let me know if you'd like to chat about this, and thank you again!

@vdauwera vdauwera self-requested a review April 14, 2025 21:30
@vdauwera vdauwera added documentation Improvements or additions to documentation Translations Support for non-English languages external labels Apr 14, 2025
@JaeungJayJang
Copy link
Contributor Author

Hello @ewels and @vdauwera! Thank you so much for your response and apoloigies for my delay.
That sounds great to me and I will look for and ask a colleague to peer-review the translations and update the branch accordingly. I will let you know once that's complete.

I'm happy to help with any future feedback or community suggestions that come up as well.

@mribeirodantas
Copy link
Member

Very excited about this PR. Looking forward to seeing it ready to merge 🤩

@epark35
Copy link

epark35 commented Apr 26, 2025

Hello, I'm @JaeungJayJang's colleague. I've reviewed the translated page of the Environment setup module from the Nextflow training material. The Korean translation preserves both technical accuracy and readability. @JaeungJayJang did a great job making the material clear and easy to understand. If you have any questions or would like additional feedback, please let me know! :)

@JaeungJayJang
Copy link
Contributor Author

Thanks for your review, @epark35! 😊
Hello @vdauwera, as previously discussed, I asked my colleague @epark35 to peer-review the translation, and she has confirmed that it looks good. I’ll proceed with updating the branch accordingly. Please let me know if there's anything else needed for this PR to move forward.

Copy link
Collaborator

@vdauwera vdauwera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for your contribution!!

@vdauwera vdauwera merged commit 57e83ab into nextflow-io:master May 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation external Translations Support for non-English languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants