-
Notifications
You must be signed in to change notification settings - Fork 199
Translate to Korean the main index page. #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate to Korean the main index page. #578
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! I saw that Korean is not currently on the list of the available language and wanted to chime in and add pages in Korean. I followed the Translating.md guide but let me know if there's anything that is further needed for this to be merged. @ewels Could you provide any feedback? Additionally, I would like to know what would be the best approach to submit multiple page translations. Should I create PR for each page, or can I keep pushing the change into this PR? |
Amazing stuff @JaeungJayJang! I'll defer to @mribeirodantas on this, as he's led the charge for translations of the training material in the past 🙏🏻 |
Hi @JaeungJayJang, thank you so much for getting this started! This poses a new challenge for us as far as reviewing the material is concerned, since we don't have anyone on the team who speaks/reads Korean, so here's what I propose.
If that works for you, please update your branch and let us know when you've had your colleague do the review, and we will merge this into the training repository. If we have community members who later flag issues or suggest improvements, can we ask you to help us review and make the relevant changes? As for translating other pages: please open new PRs for each course; so for example if you choose to translate the 'Hello Nextflow' course, we would prefer to have that in its own PR. That way we can release material bit by bit, and we avoid having very large PRs that are difficult to manage. Let me know if you'd like to chat about this, and thank you again! |
Hello @ewels and @vdauwera! Thank you so much for your response and apoloigies for my delay. I'm happy to help with any future feedback or community suggestions that come up as well. |
Very excited about this PR. Looking forward to seeing it ready to merge 🤩 |
Hello, I'm @JaeungJayJang's colleague. I've reviewed the translated page of the Environment setup module from the Nextflow training material. The Korean translation preserves both technical accuracy and readability. @JaeungJayJang did a great job making the material clear and easy to understand. If you have any questions or would like additional feedback, please let me know! :) |
Thanks for your review, @epark35! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for your contribution!!
pages translated to Korean: