Skip to content

feature: seeded random sampler #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FelixAbrahamsson
Copy link

Alternatively we create a new sampler?

Copy link
Contributor

@samedii samedii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be useful to have still and I was going to approve but it seems that the generator is changing the global random state which is probably not what we want? I am also not sure if the sampler is lazy when sampling or eager. We might want a for-loop that yields samples and switches the random state

This is still equivalent to a SequentialSampler on a shuffled dataset right so maybe there is a simpler alternative?

@samedii
Copy link
Contributor

samedii commented Mar 18, 2021

Do we still think this is useful? Have you tried it out more @FelixAbrahamsson ?

@FelixAbrahamsson FelixAbrahamsson force-pushed the master branch 3 times, most recently from b49886f to eebbf00 Compare May 4, 2021 14:14
@samedii samedii force-pushed the master branch 3 times, most recently from c39f769 to f93b796 Compare October 25, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants