Skip to content

add flag based fix to avoid default endpoint #7691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Apr 23, 2025

Proposed changes

  • This PR adds extra gates which stops mgmt cm from getting synced if controller is in shut down mode or pod is marked for deletion

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner April 23, 2025 11:49
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code labels Apr 23, 2025
@vepatel vepatel requested review from AlexFenlon and pdabelf5 April 23, 2025 11:50
Copy link

codecov bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.18%. Comparing base (e52961b) to head (314e251).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/configmap.go 0.00% 8 Missing ⚠️
cmd/nginx-ingress/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7691   +/-   ##
=======================================
  Coverage   52.17%   52.18%           
=======================================
  Files          89       89           
  Lines       21265    21290   +25     
=======================================
+ Hits        11096    11111   +15     
- Misses       9705     9715   +10     
  Partials      464      464           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Uninstalling helm chart can cause issues with NGINX Plus mgmt config
2 participants