feat: a bit more useful NgxStr #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xeioex
approved these changes
May 31, 2025
From implementations for NgxStr allowed to create a reference that lives longer than the original object.
fmt::LowerHex was applying the inherited Formatter options, resulting in the following incorrect output: ``` assertion `left == right` failed left: "\\x f0\\x 90\\x 80" right: "\\xf0\\x90\\x80" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for the allocator-api work, but useful on its own.
nginx_sys::detailcould be another crate (nginx-common?), but there's just not enough code to split it now.fmt::Debugforngx_str_t. Need to figure out how to override bindgen generated trait implementation without nuking Debug impls from most of the bindings.Builder::no_debug()does exactly that -- omitsDebugon thengx_str_titself and on any structs that includengx_str_trecursively.display_bytes, but apparently precision requires a honest UTF-8 character width detection algorithm (unicode-width). The code without that can panic on an attempt to break an UTF-8 sequence. Maybe next time.I wish I could replace NgxStr with
bstr, but it does not offer allocators support :(