Skip to content

skip docs for lib/fusion (docs already run in fusion repo) #16645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jan 8, 2021

fixes following bugs:

(note: also fixed ci docs but #16644 was merged in meantime; but the other points remain)

future work: don't copy fusion inside lib/fusion

  • un-bundle nim and fusion (which was a root cause for this issue). As I've argued in instead of copyDir(fustion, stdlib/lib), update --path fusion#25, copying over fusion in nim lib/fusion/ is a terrible idea.
    • It breaks repo modularity
    • prevents switching between branches (which have a different fusion hash in koch.nim)
    • affects tooling (as this issue showed)
    • will cause nasty issues if user imports external fusion (since each fusion module will end up as 2 distinct module, breaking exportc and other things), etc

@timotheecour
Copy link
Member Author

timotheecour commented Jan 8, 2021

wrong link, i think you meant https://github.com/nim-lang/Nim/pull/16644/files ;

but this PR is better, it also prevents future such regressions thanks to the change in .github/workflows/ci_docs.yml :)

EDIT: now that #16644 was merged, i updated this PR to also skip docs for fusion entirely, see PR message for rationale + details)

@timotheecour timotheecour force-pushed the pr_fix_ci_docs_fusion branch from 91d97f4 to 4da22ac Compare January 8, 2021 20:09
@timotheecour timotheecour changed the title fix broken CI docs skip docs for lib/fusion (docs already run in fusion repo) Jan 8, 2021
@timotheecour timotheecour requested a review from ringabout January 8, 2021 21:23
@Araq
Copy link
Member

Araq commented Jan 8, 2021

Merging this now, we can do some followup PRs if it's still wrong.

@Araq Araq merged commit ffb130b into nim-lang:devel Jan 8, 2021
@timotheecour timotheecour deleted the pr_fix_ci_docs_fusion branch January 8, 2021 22:27
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
…g#16645)

* run CI docs on koch.nim changes to avoid future regressions

* kochdocs: skip lib/fusion
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
…g#16645)

* run CI docs on koch.nim changes to avoid future regressions

* kochdocs: skip lib/fusion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants