Skip to content

Improve documentation for options #17036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2021
Merged

Conversation

konsumlamm
Copy link
Contributor

@konsumlamm konsumlamm commented Feb 14, 2021

  • improve wording
  • clarify behaviour for pointers
  • improve runnableExamples

Future work

Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one remark, the rest looks good.

@timotheecour timotheecour merged commit f400b5c into nim-lang:devel Feb 18, 2021
@timotheecour timotheecour added the TODO: followup needed remove tag once fixed or tracked elsewhere label Feb 18, 2021
@konsumlamm
Copy link
Contributor Author

@timotheecour I think you can remove the TODO: followup needed label now (unless you were referring to #17036 (comment)).

@timotheecour
Copy link
Member

I was referring to #17036 (comment) indeed, but here's the PR: #17147

@timotheecour timotheecour removed the TODO: followup needed remove tag once fixed or tracked elsewhere label Feb 22, 2021
@konsumlamm konsumlamm deleted the options branch February 23, 2021 12:07
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants