don't warn/error symbols in semGenericStmt/templates #24907
Conversation
compiler/semtempl.nim
Outdated
| @@ -72,7 +72,7 @@ proc symChoice(c: PContext, n: PNode, s: PSym, r: TSymChoiceRule; | |||
| incl(s.flags, sfUsed) | |||
| markOwnerModuleAsUsed(c, s) | |||
| else: | |||
| markUsed(c, info, s) | |||
| markUsed(c, info, s, inGenerics = inGenerics) | |||
There was a problem hiding this comment.
Instead of modifying markUsed, just triggering the if branch above (i.e. if isField or inGenerics: rather than if isField:) should be enough.
Also this should apply to templates as well as generics. Another option might be to make the top if branch the default behavior for symChoice and call markUsed manually when the produced node is an nkSym. The only place where this isn't already done and isn't in generics/templates seems to be semexprs.semSymGenericInstantiation.
There was a problem hiding this comment.
It would be good to detect it early but then the when false case would still be a problem, especially with --styleCheck:error. Depends whichever behavior is less annoying.
ringabout
changed the title
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
fixes #24905
fixes #24903
fixes #11805
fixes #15650
In the first phase of generic checking, we cannot warn/error symbols because they can belong a false branch of
whenor there is apush/popoptions using open symbols. So we cannot decide whether to warn/error or not