Improve documentation #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
another small incremental improvement for documentation:
There is one element of TODO list that I think it should not be an issue anymore (since there are no more nil for sequences) and so I did not list it in current limitations: "Fix the templates so they work with uninitialized (nil) values!"
Let me know what you think.
Regarding possible API changes in the future I have always wondered why Negative is an enum instead of a bool (where there other flags at the beginning?), but for the moment this is just curiosity, plan is still to fix outstanding issues before thinking of the improvements. I am enjoying the process and learning quite a bit, the code is very terse.
In the meantime I have started to work on #26 (see https://github.com/pietroppeter/nim-bigints/tree/fix-empty-limbs). I think there are many places where empty limbs might raise an issue, the plan is map them feature by feature with failing tests and fix them one by one. I will open a draft PR when I complete fixes for the compare operators and proceed from there.
Also notable is a new bigints library that was born a couple of days ago and which probably aims to have same footprint as bigints (I do expect it to progress fast and be very performant given its author): https://github.com/SciNim/megalo/tree/master/megalo