Skip to content

Fix empty limbs #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 12, 2020
Merged

Fix empty limbs #33

merged 10 commits into from
Oct 12, 2020

Conversation

pietroppeter
Copy link
Contributor

@pietroppeter pietroppeter commented Oct 6, 2020 •
edited
Loading

Fixes #26 handling @[] the same as @[0]

  • comparison
  • addition/subtraction
  • multiplication
  • others place where empty limbs can cause issues? did not find any. division looks fine
  • bump version
  • update readme (rebase on current master)
  • cleanup
  • rerun mddoc (since public interface change, see below)

other change in this PR: one and zero are now public.

@pietroppeter pietroppeter marked this pull request as ready for review October 12, 2020 16:32
@def-
Copy link
Member

def- commented Oct 12, 2020

Nice, thanks!

@def- def- merged commit d48cec7 into nim-lang:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty limbs when uninitialized
2 participants
@pietroppeter @def-